hasse69 / rar2fs

FUSE file system for reading RAR archives

https://hasse69.github.io/rar2fs/

GNU General Public License v3.0

279 stars 27 forks source link

Doesn't build in LLVM Clang 6.0 #87

Closed zappepappe closed 6 years ago

zappepappe commented 6 years ago

LLVM Clang recently switch to building with C++14 by default and rar2fs doesn't build with the error: dllext.cpp:47:18: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]

define St(x) L""x""

With an arrow pointing at the x.

hasse69 commented 6 years ago

Thanks for the issue report. This problem was reported as early as April 2016 in issue #48. Unfortunately one occurrence of this violation was left in the code, even in the same file, which makes we wonder what was really fixed here :( I will update and push to master ASAP.

hasse69 commented 6 years ago

Patch pushed to master, please report back since I do not have a proper working C++14 environment to try this on.

zappepappe commented 6 years ago

Don't really have a proper environment either. Just tried building it in a VM and it builds fine with the patch. If you would like me to check if it works properly I will have to transfer some rar files over and check.

hasse69 commented 6 years ago

Thanks, building should be enough. This does not really affect any functionality. Will close the issue.