erwin-willems
commented
8 months ago @frenck What is needed to get this one merged? (or closed with comment, which is also fine of course)
Closed erwin-willems closed 1 month ago
erwin-willems
commented
8 months ago @frenck What is needed to get this one merged? (or closed with comment, which is also fine of course)
LordNex
commented
8 months ago You might want to add the ability of which VLAN Interface you want it to listen on. I have a bug report out there now because I have a miltisubnetted network Main/IoT/Guest, that way all my IoT traffic doesn't interfere with my other device and such. Currently there is no standard way to define which interface it will pick as it's “default” interface. I'm running IPV6 on all my subnets as well. Not as important there but it still seem to cause issues from time to time. See 84113
osh123
commented
7 months ago any chance of this being merged? ipv6 is unusable without this :|
danielszilagyi
commented
6 months ago any chance of this being merged? ipv6 is unusable without this :|
Great that I found this before forking the official repo. I think the test output should be checked and the labels adjusted at least to get this merged. Actually, I just wanted to get away with being able to configure locServedNets (https://github.com/AdguardTeam/AdGuardHome/issues/3142) from the addon config but seems this PR is about a different IPv6 related issue.
osh123
commented
6 months ago Until we get a fix, I used socat to redirect traffic from fe80:: IP to the IPv4 one:
socat -T 1 UDP6-LISTEN:53,fork,reuseaddr,bind=[$IPV6%$IPV6_INTERFACE] UDP4:$IPV4Just replace $IPV6 with the fe80 address, $IPV6_INTERFACE with the network interface (in my case it was enp2s0) and $IPV4 with the IPv4 address.
I've set it up as service:
[Unit]
Description=Forwards ipv6 link-local udp port 53 to IPv4 udp
[Service]
Type=simple
ExecStart=-/usr/bin/socat -T 1 UDP6-LISTEN:53,fork,reuseaddr,bind=[$IPV6%%$IPV6_INTERFACE] UDP4:$IPV4
ExecStop=-/usr/bin/killall socat
Restart=on-failure
RestartSec=1s
[Install]
WantedBy=multi-user.targetit's not the best solution, but its working for me for the past few days.
github-actions[bot]
commented
5 months ago There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
snapsl
commented
5 months ago Tested and it works. Can this PR be merged so everyone can use this?
Amit-Shan
commented
4 months ago Thumbs up for this PR. Hopefully, it can be merged soon.
github-actions[bot]
commented
3 months ago There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
jenschude
commented
3 months ago Is there a possibility to get this approved? I get a new IPv6 address assigned on reconnect of the Internet and then all network devices also get new addresses. Listening to the link local address would provide a stable address for home network devices.
snapsl
commented
3 months ago @frenck pls, review.
erwin-willems
commented
3 months ago Just updated / rebased this PR. You can test / use this fix via https://github.com/erwin-willems/hassio-addons
jenschude
commented
2 months ago @erwin-willems can you add a label like enhancement ? The CI build fails atm due to a missing label in the PR
erwin-willems
commented
2 months ago I don't know how to add labels. Have the feeling that I don't have permission for that
Amit-Shan
commented
2 months ago I don't know how to add labels. Have the feeling that I don't have permission for that
It seems like someone else added the label. Now, it says all checks have passed. I assume this means that @frenck just needs to authorize the commit after reviewing it. Fingers crossed no other issues show up.
github-actions[bot]
commented
1 month ago There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
Amit-Shan
commented
1 month ago Not stale.
frenck
commented
1 month ago @coderabbitai review
coderabbitai[bot]
commented
1 month ago coderabbitai[bot]
commented
1 month ago The update to the init-adguard/run script focuses on refining IP address management. It now adeptly handles IPv4 and IPv6 addresses from interfaces, eliminates netmasks, and incorporates addon and localhost IP addresses for enhanced network functionality.
| Files | Change Summary |
|---|---|
adguard/rootfs/.../init-adguard/run |
Updated IP address handling to manage IPv4 and IPv6 addresses, exclude netmasks, and add addon and localhost IPs. |
🐇 In scripts where data flows so free, New IPs dance with IPv4 and IPv6 glee, Addon and localhost join the spree, Binding together in harmony, A network symphony, for all to see. 🌐✨
[!TIP]
New Features and Improvements
## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Proposed Changes
IPv6 Link Local Addresses (fe80) were skipped during the configuration of the interface binding. A use case could be to run your DNS server on address fe80::53 on all your networks. For this LLA should be supported.
For LLA binding, the interface name needs to be added to the binding. Like: fe80::53%enp1s0. I've rewritten the script to parse LLA with interface bindings.
This PR can be tested on my Dev repository: https://github.com/erwin-willems/hassio-addons
Related Issues
Summary by CodeRabbit