hassio-addons / addon-adguard-home

AdGuard Home - Home Assistant Community Add-ons
https://addons.community
MIT License
374 stars 47 forks source link

Security Hotfix in v0.107.48 - Please trigger release - Access settings not being applied to encrypted protocols #514

Closed mxbchr closed 2 months ago

mxbchr commented 2 months ago

Problem/Motivation

Hey @frenck - I'm sorry to hit you up for this. As stated in the AdGuard Home Changelog for v0.107.48: "After the last update it became possible for banned users to make DNS queries over encrypted protocols. This behavior, of course, was not intended, and is fixed by this hotfix."

Unfortunately the Version of AdGuard Home this Addon currently uses is v0.107.47, the one where the Access settings don't work. I'm getting more and more unauthorized requests that would normally be blocked.

I see that you already merged the update to v0.107.48 in the Dockerfile ten days ago, but didn't trigger a new release yet. Per the changelog of AdGuard Home fixing the "Access settings not being applied to encrypted protocols" is the only change in v0.107.48, so it seems this shouldn‘t require extensive testing. Can you please trigger the release?

Thank you for all your hard work for the HA-Community!

Expected behavior

Banned/non-whitelisted clients should not be able to send DoT/DoH requests to AdGuard.

Actual behavior

Banned/non-whitelisted clients should not be able to send DoT/DoH requests to AdGuard.

Steps to reproduce

AdGuard Home Addon with DoT/DoH port open to the Internet and Access configured only for whitelisted clients.

Proposed changes

Update to v0.107.48 already merged in the Dockerfile. Trigger a new release of this Addon.

frenck commented 2 months ago

Sorry, releases don't happen this way. Next iteration will happen eventually.