hassio-addons / addon-aircast

AirCast - Home Assistant Community Add-ons
https://addons.community
MIT License
314 stars 18 forks source link

add dark icons #141

Closed velijv closed 2 years ago

velijv commented 2 years ago

Proposed Changes

add dark icons because black on black is stylish but illegible. 🌓 #140

Related Issues

(Github link to related issues or pull requests)

frenck commented 2 years ago

How did the testing go?

velijv commented 2 years ago

@frenck I havent figured out how to add label to pull request, even google isnt my friend 🤐

frenck commented 2 years ago

I havent figured out how to add label to pull request

That is not something you have to worry about. That is a categorization task for me.

Nevertheless, the question remains: How did the testing go?

velijv commented 2 years ago

Before: 👎 image

After: 👍 image

frenck commented 2 years ago

It's interesting, as the Supervisor API doesn't support it... Nor does it support hDPI images.

velijv commented 2 years ago

Ah okay, didn't know that. Assumed it worked the same way as official icons. Based them on my original icons. Should I create a colored version instead, that can be used in both light and dark modes?

Since it is a butchered mashup of both, it doesn't have to follow any guides, but both seem to use monochrome:

This is exactly between #000 and #fff Group 140

velijv commented 2 years ago

Since Cast https://github.com/home-assistant/brands/pull/3067 updated its logo, maybe it's time to update Aircast as well?

Sorry Google, Sorry Apple Frame 1

frenck commented 2 years ago

I don't see how that is related to this PR.

Anyways, this PR cannot work, as the Supervisor has no support for this. The hDPI images also don't work.

Closing this PR for now for that reason.