hassio-addons / addon-appdaemon

AppDaemon4 - Home Assistant Community Add-ons
https://addons.community
MIT License
160 stars 49 forks source link

docs: fix failing example #151

Closed xaviml closed 3 years ago

xaviml commented 3 years ago

Hi there,

Since the last addon update, numpy and pillow (maybe others) seemed to be broken when installed through pip. See here:

It seems that this latest image is giving problems with Python C extension libraries. For example, this used to work:

system_packages: []
python_packages: [Pillow]
init_commands: [python3 -c 'from PIL import Image']

Now this needs to be translated to:

system_packages: [py3-pillow]
python_packages: []
init_commands: [python3 -c 'from PIL import Image']

The same happens with Numpy.

Proposed Changes

This PR suggests changing the Pillow from python package to system package (py3-pillow). I totally understand this is just a documentation example, but in my opinion, it makes more sense to have a working example rather than a broken one.

Regards, Xavi M.

frenck commented 3 years ago

I don't want to adjust that.

The main reason; is that it shows an example of how to use the configuration, it is not meant to be cut and pasted. For that reason, I'm actually perfectly happy with the fact it doesn't work.

Nevertheless, thanks for willing to contribute 👍