search

hassio-addons / addon-bitwarden

Vaultwarden (Bitwarden) - Home Assistant Community Add-ons
https://addons.community
MIT License
156 stars 43 forks source link

Allow configuration for Push Notification parameters #306

Closed markusmauch closed 1 month ago

markusmauch commented 5 months ago

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables:

PUSH_ENABLED=true PUSH_INSTALLATION_ID=.... PUSH_INSTALLATION_KEY=.... PUSH_RELAY_BASE_URI=https://push.bitwarden.com

I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables.

See also here: https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/ https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

pmetzke commented 4 months ago

@markusmauch - thanks for testing to see if this would work!

It would be awesome to get these settings in the addon configuration.

Salvora commented 4 months ago

Also, waiting for this. Additionally, if we can define environment variables. It is also possible to use MySQL or MariaDB as backend. https://github.com/dani-garcia/vaultwarden/wiki/Using-the-MariaDB-%28MySQL%29-Backend

dewet22 commented 4 months ago

Another 2p: I'd like to set the DOMAIN variable to enable U2F / FIDO2 WebAuthn.

cuza commented 4 months ago

@dewet22

Another 2p: I'd like to set the DOMAIN variable to enable U2F / FIDO2 WebAuthn.

You can set that in the vaultwarden admin page (/admin) and use U2F / FIDO2 WebAuthn without problems

image
dewet22 commented 4 months ago

You can set that in the vaultwarden admin page (/admin) and use U2F / FIDO2 WebAuthn without problems

So odd! I don't remember seeing that at all. I ended up hosting vaultwarden on my homelab instead where I have better storage protection / backups anyway, but thanks for the tip!

neckaros commented 3 months ago

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables:

PUSH_ENABLED=true PUSH_INSTALLATION_ID=.... PUSH_INSTALLATION_KEY=.... PUSH_RELAY_BASE_URI=https://push.bitwarden.com

I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables.

See also here: https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/ https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

You mean editing the config.yaml on this repo or you did a modification on your installation? First time looking at a HA addon but i think config.yaml is indeed where the magix should happen. Can you send a merge request if you successfully did it?

StrausFuenf commented 3 months ago

Problem/Motivation

Vaultwarden allows to set up Push Notification to send authentication requests from the web extension to the mobile app in order to use biometric authentication. The respective settings can be provided via environment variables: PUSH_ENABLED=true PUSH_INSTALLATION_ID=.... PUSH_INSTALLATION_KEY=.... PUSH_RELAY_BASE_URI=https://push.bitwarden.com I tried to edit the config.json in the data directory of the addon accordingly and was able to set up Push Notifications. So it's just a matter of adding the settings in the addon configuration and start the vaultwarden container with theses additional env variables. See also here: https://2nistech.world/vaultwarden-activate-push-notification-for-mobile-devices/ https://github.com/dani-garcia/vaultwarden/wiki/Enabling-Mobile-Client-push-notification

Expected behavior

It should be possible to specify push notification settings in configuration of the addon

Actual behavior

It is not possible to specify push notification settings in configuration of the addon

Steps to reproduce

Proposed changes

You mean editing the config.yaml on this repo or you did a modification on your installation? First time looking at a HA addon but i think config.yaml is indeed where the magix should happen. Can you send a merge request if you successfully did it?

Its possible I forked this repo and made it possible. frenck already had another Issue with that and moved it to the Discussions tab.

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

Salvora commented 2 months ago

bump

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!