search

hassio-addons / addon-firefly-iii

Firefly-III - Home Assistant Community Add-ons
https://addons.community
MIT License
17 stars 11 forks source link

Maps not showing / Location cannot be set for tags #8

Closed marecabo closed 4 years ago

marecabo commented 4 years ago

Problem/Motivation

A location can be assigned to a tag in Firefly III and a map can be shown of that location on the tag's page if a Mapbox API key is configured. See Tags - Firefly III Documentation for details.

As there is no Mapbox API key available to the addon, locations cannot be added to tags and a map for tags with a location already assigned does not show.

image This is the message which appears instead of the location input field when creating a tag.

There is currently no option to specify one's individual Mapbox API key in the options to pass it to the addon, but it would be great if there would be one.

Expected behavior

The addon allows to edit/add locations of tags and shows their location on a map.

Actual behavior

The addon does not show a map with the tag's location.

Steps to reproduce

Create a tag and attempt to assign a location to it.

Proposed changes

I followed the official addon developer documentation to add a mapbox_api_key option here: https://github.com/marecabo/addon-firefly-iii/commit/3bf16ac1354397064f51e6c3ed1307bbc9c94b34

addons-assistant[bot] commented 4 years ago

:wave: Thanks for opening your first issue here! If you're reporting a :bug: bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be useful.

sinclairpaul commented 4 years ago

Closed by #9 😄

addons-assistant[bot] commented 4 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.