search

hassio-addons / addon-ftp

FTP - Home Assistant Community Add-ons
https://addons.community
MIT License
63 stars 23 forks source link

i_like_to_be_pwned: true option doesn't work #194

Closed aotd1 closed 2 months ago

aotd1 commented 3 months ago

Problem/Motivation

I want to use "123456" password for testing purposes. Use this config:

port: 21
data_port: 20
banner: Welcome to the Hass.io FTP service.
pasv: true
pasv_min_port: 30000
pasv_max_port: 30010
pasv_address: ""
ssl: false
certfile: fullchain.pem
keyfile: privkey.pem
implicit_ssl: false
max_clients: 5
users:
  - username: admin
    password: 123456
    allow_chmod: false
    allow_download: true
    allow_upload: true
    allow_dirlist: true
    addons: false
    backup: false
    config: true
    media: true
    share: true
    ssl: false
i_like_to_be_pwned: true

Expected behavior

I can save configuration. Server is running correctly.

Actual behavior

Trying to save config got error:

image

Can't start service:

[11:03:14] INFO: Starting Log tailer...
s6-rc: info: service init-vsftpd successfully started
[11:03:14] WARNING: Password is in the Have I Been Pwned database!
[11:03:14] WARNING: Password appeared 171031 times!
[11:03:14] FATAL: 
[11:03:14] FATAL: We are trying to help you to protect your system the
[11:03:14] FATAL: best we can. Therefore, this add-on checks your
[11:03:14] FATAL: configured password against the HaveIBeenPwned database.
[11:03:14] FATAL: 
[11:03:14] FATAL: Unfortunately, your configured password is considered
[11:03:14] FATAL: unsafe. We highly recommend you to pick a different one.
[11:03:14] FATAL: 
[11:03:14] FATAL: Please change the password in the 'users[0].password' option.
[11:03:14] FATAL: 
[11:03:14] FATAL: Check the add-on manual for more information.
[11:03:14] FATAL: 
s6-rc: warning: unable to start service init-users: command exited 1

Steps to reproduce

Set i_like_to_be_pwned option to true, use weak password for user (123456 for example)

Proposed changes

nope

aotd1 commented 3 months ago

Home Assistant Core 2024.6.3 Supervisor 2024.06.0 Operating System 12.4 Frontend 20240610.1

Addon version: 5.0.2

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!