search

hassio-addons / addon-grafana

Grafana - Home Assistant Community Add-ons
https://addons.community
MIT License
213 stars 61 forks source link

Do not install Grafana Image Renderer plugin by default #384

Closed t-o-o-m closed 5 months ago

t-o-o-m commented 5 months ago

Proposed Changes

Do not install Grafana Renderer Plugin by default on amd64 architectures. Any user who wants to use this plugin can add it to the list of plugins as described in the documentation like they would with any other desired plugin.

This is currently the only plugin installed by default, and as a user not looking at the source code it is not obvious why this plugin is installed and running. Additionally I can't remove the plugin since it will be reinstalled after every addon-reboot.

Also this plugin uses up CPU even when not in use (see #380).

Related Issues

380

frenck commented 5 months ago

What would be the use case?

t-o-o-m commented 5 months ago

As mentioned in #380 the image renderer plugin is using up CPU even when not in use. In an effort to keep my overall CPU/energy usage down I currently have to manually kill the image renderer plugin process after every grafana add-on reboot.

frenck commented 5 months ago

As mentioned in https://github.com/hassio-addons/addon-grafana/issues/380

Cool, but let's make sure we make PRs complete in what they try to achieve. The description of the PR isn't providing motivation.

t-o-o-m commented 5 months ago

Adapted the description.

Regarding breaking change on update: would it be reasonable/possible to add the renderer plugin to the list of plugins in the config of all amd64 instances upon updating the addon? This would keep the renderer plugin running for all instances it was currently installed on by default plus it would make the install of this plugin transparent. Users like me could then remove the plugin from the list, and all the other ones would not have to change anything to keep the current behaviour/functionality.

Sounds like a bit of hassle to me, though, since this adding-to-the-list action should only happen exactly once and only when updating the addon from the opaque (current) behaviour to the transparent (proposed) behaviour.

t-o-o-m commented 5 months ago

All in all it seems I have made a quick shot here :) Will therefore close the MR and use a fork locally for now.

Thank you anyways - for all your contributions, not just for this!