search

hassio-addons / addon-grafana

Grafana - Home Assistant Community Add-ons
https://addons.community
MIT License
228 stars 64 forks source link

Duplicate Sidebar Icon with old icon broken #57

Closed tscs37 closed 4 years ago

tscs37 commented 4 years ago

Problem/Motivation

When upgrading to the latest version with the sidebar icon enabled via "Show in Sidebar" the icon is duplicated; one of the icons leads to a 502 page, the other leads to grafana proper.

Expected behavior

Upgrading to the latest version should update the sidebar icon to the new ingress

Actual behavior

The sidebar icon shows for both the old and new ingress, the old icon does not work at all and leads to an error page.

Steps to reproduce

  1. Setup Hass.io with the old version (<3.0.0)
  2. Activate Sidebar Icon
  3. Upgrade to latest version (3.0.0)
  4. The old Sidebar Icon is now broken
  5. De- and Reactivate Sidebar Icon

Proposed changes

The Addon should clear the old icon before or after upgrading, this was likely introduced when the addon changed to the new ingress method.

addons-assistant[bot] commented 4 years ago

:wave: Thanks for opening your first issue here! If you're reporting a :bug: bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

frenck commented 4 years ago

Correct, that is why instructions for this where written in the release notes: https://github.com/hassio-addons/addon-grafana/releases/tag/v3.0.0

GitHub
hassio-addons/addon-grafana
Grafana - Community Hass.io Add-on for Home Assistant - hassio-addons/addon-grafana
addons-assistant[bot] commented 4 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.