search

hassio-addons / addon-grocy

Grocy - Home Assistant Community Add-ons
https://addons.community
MIT License
319 stars 60 forks source link

patch: fix error on startup #397

Closed matttbe closed 12 months ago

matttbe commented 1 year ago

Proposed Changes

I noticed on the ticket 391 that this patch cannot be applied properly on the last version:

INFO: Patching Grocy to fix relative URL handling...
patching file views/layout/default.blade.php
Hunk #1 FAILED at 88.
1 out of 1 hunk FAILED -- saving rejects to file views/layout/default.blade.php.rej

I simply tried to apply the patch on top of the latest v4.0.3 release and fixed the conflicts. The context has changed in v4.0: ActiveNav variable has been replaced by View in commit d16d976d0 ("Simplified viewjs / active page handling") in Grocy repo.

Related Issues

I don't know if this will fix the recent issues that have been reported (391, 392, 395) because I'm not using this addon yet: I was looking at trying it and I wanted to fix this issue first. That's why I didn't "link" this PR to these issues.

matttbe commented 1 year ago

Regarding the failure reported by the CI, please add the bugfix label: it looks like I don't have the permission to do that.

matttbe commented 12 months ago

@frenck thank you for having approved this PR!

The CI complained about my initial patch which was 2 weeks old. After having synced my branch with the main one, all checks have passed now!