hassio-addons / addon-mqtt

MQTT Server & Web client - Home Assistant Community Add-ons
https://addons.community
MIT License
35 stars 15 forks source link

"Open Web UI" uses HTTPS with ssl disabled #40

Closed brianhanifin closed 5 years ago

brianhanifin commented 5 years ago

Problem/Motivation

I fought with this for hours in Safari, just to discover an SSL error in Chrome. Shame on me, I should have tried that sooner. 🤦‍♂

My server is behind Wireguard so is not public facing, so I am no longer concerned with SSL.

Expected behavior

When "ssl": false is set, http should be the chosen protocol instead of https. Desired URL = http://[localip]:5713

Actual behavior

The browser opened with https://[localip]:5713.

Steps to reproduce

{
  "log_level": "info",
  "certfile": "",
  "keyfile": "",
  "web": {
    "enabled": true,
    "ssl": false
  },
  "broker": {
    "enabled": true,
    "enable_ws": true,
    "enable_mqtt": true,
    "enable_ws_ssl": false,
    "enable_mqtt_ssl": false,
    "allow_anonymous": true
  },
  "mqttusers": [
    {
      "username": "mqttusername",
      "password": "mqttpassword",
      "readonly": false,
      "topics": [
        "#"
      ]
    }
  ],
  "leave_front_door_open": true
}

Proposed changes

I propose that you add an if statement when defining the OPEN WEB UI url. 😉

addons-assistant[bot] commented 5 years ago

:wave: Thanks for opening your first issue here! If you're reporting a :bug: bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

frenck commented 5 years ago

Unfortunately, this cannot be dynamically changed in this case. This is an Hass.io limitation.

Closing issue.

addons-assistant[bot] commented 5 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.