search

hassio-addons / addon-nginx-proxy-manager

Nginx Proxy Manager - Home Assistant Community Add-ons
https://addons.community
MIT License
327 stars 102 forks source link

Addon installation corruption from SSL cert removal #586

Closed number65259 closed 1 month ago

number65259 commented 2 months ago

Problem/Motivation

Addon install completely failed after removing two SSL certs in the UI. #536 , #562 , #581 possibly related.

Expected behavior

Addon properly tracks SSL certs to avoid a corrupted internal state, if a corrupted internal state is encountered it doesn't nuke the addon install, and as a bonus it should renew SSL certs without me having to manually remove and readd proxies or certs in the UI.

Actual behavior

SSL certs were removed in the UI. Webapp then started throwing errors about a missing cert in logs. In this state the addon won't successfully start. On attempted reinstall of the addon, Home Assistant then throws an error that the addon logs can not be found, and removes the app from the addons list. Addon files are still located on the hassOS drive.

Steps to reproduce

Delete SSL certs from the SSL certs tab after they expire due to #400 , #462 , #517, #554 etc.

Proposed changes

Fix #400 , #462 , #517, #554 etc. so SSL certs refresh on their own and the addon doesn't catastrophically fail from an unexpected SSL state when removal is attempted.

Thanks

Thanks for all your work. When the package is functional, it is very convenient.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

number65259 commented 1 month ago

Please make sure to update to the latest version and check if that solves the issue.

Ended up moving to the source NPM container outside of Home Assistant so I could do just that. Closing this since I won't be able to help troubleshoot the Home Assistant Add On - never bothered reinstalling after all that. For anyone else struggling with this package that is capable of managing their own docker setup:

Install instructions: https://nginxproxymanager.com/setup/ Repo: https://github.com/NginxProxyManager/nginx-proxy-manager