Closed dedepene closed 2 years ago
I have the same issue. I rolled back 1 week and everything worked fine.
I have the same issue. I rolled back 1 week and everything worked fine.
no such luck here as I accidentally deleted my snaphots. Did you restore just node red or the entire snapshot?
Also, in my case I can get it properly showing debugging if I reach the web ui through the configured port in a separate browser tab. Did you try this?
Did you restore just node red or the entire snapshot?
Actually, I am running HA on a VM under Proxmox with automatic backups. I just restored one of the earlier VMs. I initially tried the last one but still had the issue so I picked one where NodeRed was at version 9.0.1. This is one of the many advantages of running HA on Proxmox.
So when I run node-red in a separate browser tab through the config port, I seem to get superhigh CPU usage on account of the nodered container. The processes inside the container is listed here:
Also, this time around I'm getting the supervisor log spammed with these :
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:57 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:58 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:16:59 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] WebSocket access from a0d7b954_nodered
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:00 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request running
21-06-01 10:17:01 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API request initialize
I had a smiliair issue socket error and most of the time no debug info. (yes sometimes briefly debug/status was displayed). I solved it partly by entering a port number in the network part of the add-on (used port 1880). after restarting. After wich I direct connect to node red <http://192,168.x.x:1880) logon with your home assistant password. When starting node-red inside home assistant no debug info...
I had a smiliair issue socket error and most of the time no debug info. (yes sometimes briefly debug/status was displayed). I solved it partly by entering a port number in the network part of the add-on (used port 1880). after restarting. After wich I direct connect to node red <http://192,168.x.x:1880) logon with your home assistant password. When starting node-red inside home assistant no debug info...
This is precisely what I'm doing for the moment - loading node red in a separate browser via the port I opened in config. Still, this is only a workaround, and also started getting these massive CPU overloads on account of the node-red container.
I wonder if anyone is actually looking into this?
I am doing the same thing. Direct connect for now. I've updated everything and even uninstalled and reinstalled node red.
Same issue here
I have the same problem. node red 9.1.3
same problem, on version 9.1.3
updated to version 9.1.4 the problem remains the same
Same here, but as far as I take the changelog there isn't a specific update to this issue, more a general update, as different containers of the communityaddons where updated.
I can also confirm 9.1.4 did not fix the issue.
Have the same problem. Latest config 9.1.4
Issue still exists in 9.14. Also seeing huge CPU spikes (>26%) and during the spikes most flows are slow and lagging. If the CPU is running normal (<6%) all flows works perfect. Running on a nuc celeron j3455
Yep same issue as everyone else.
I removed the add-on and folders, rebuilt and have at least the connection. But it failed to run and run debug. The connection and "visual" only worked in the app. The debug doesn't work at all.
I had a similar issue a while back also, I'm not sure if that was related to update or not. But that absolutely is. It worked until update.
Edit - This is running supervisor on a pi4 4gb
Since I have several Home Assistannt instances running I decided to Install Node Red on my PI. (Same version's as on the NUC). And to my suprise debug and status worked...
Since I have several Home Assistannt instances running I decided to Install Node Red on my PI. (Same version's as on the NUC). And to my suprise debug and status worked...
So where does that take us? Something else is breaking node-red?
Interesting. Is everyone with issues running on a NUC and could this somehow be causing the problem? My setup is using a NUC running with HA running on a VM under proxmox. I now have a Synology NAS where I could easily install HA for testing purposes.
Interesting. Is everyone with issues running on a NUC and could this somehow be causing the problem? My setup is using a NUC running with HA running on a VM under proxmox. I now have a Synology NAS where I could easily install HA for testing purposes.
I'm on bare-metal x64 thin client, no virtualization whatsoever.
I spent an AGE dealing with, I had this issue before or similar so tired again and it worked.
Make a copy of your flows. uninstall nodered Remove ALL nodered files - EVERYTHING Reboot Install nodered again but NOT using the "i use the homeassistant add on" using the IP and a token. reconfigure all the dam nodes (im sure there is a faster way but i dont have many flows to deal with) It's the only way I could get it working at all
Also in a bizarre way the nodered portal app I can see debug info , but not on chrome
Interesting. Is everyone with issues running on a NUC and could this somehow be causing the problem? My setup is using a NUC running with HA running on a VM under proxmox. I now have a Synology NAS where I could easily install HA for testing purposes.
I am running W10 with HA in hyper-V.
I spent an AGE dealing with, I had this issue before or similar so tired again and it worked.
Make a copy of your flows. uninstall nodered Remove ALL nodered files - EVERYTHING Reboot Install nodered again but NOT using the "i use the homeassistant add on" using the IP and a token. reconfigure all the dam nodes (im sure there is a faster way but i dont have many flows to deal with) It's the only way I could get it working at all
Also in a bizarre way the nodered portal app I can see debug info , but not on chrome
Will try this solution and post the outcome.
Indeed removing node red also the directory located under config. Reboot and reinstall did the job .... for 5 minutes and then the debug/status info disappeared again. ..
.. A little but too fast... Updated the Home Assistant flow (as described by Th00mas88) and restarted node red. (debug/status appeared and stayed .. Yess).. Also CPU is back to normal again (5-9%)
Indeed removing node red also the directory located under config. Reboot and reinstall did the job .... for 5 minutes and then the debug/status info disappeared again. ..
.. A little but too fast... Updated the Home Assistant flow (as described by Th00mas88) and restarted node red. (debug/status appeared and stayed .. Yess).. Also CPU is back to normal again (5-9%)
It's now been 12 ? 36 hours since I did it and got all working.
It still seems I'm missing debug in chrome but on the app it's there
Same issue here. Running HAOS under proxmox on x64
OK, I used a modified @th00mas88 method to upgrade my Node-Red to the latest version:
I used the homeassistant addon. I did this two days ago.
I have the same issue since a couple of weeks, running NR 9.2.0 i noticed some flows responding very slow. When i open NR and looked what caused it i noticed allot "call service" nodes are stuck at sending
All ready tried to completley removed node red and install again but now on server with token, worked for an hour or so but things got worse. Now i'm back on "i use the add_on" and couple times a day the delays are serval minutes.
Allready started over twice this weekend but no luck, flows are still lagging cause status keeps beeing stuck at sending so allot of flows don't work anymore. Any idea?
I am also experiencing this same issue. I might migrate out of the HASSIO addon for Node Red and just install it as a Docker anyway, but this is kind of a bummer.
I had a smiliair issue socket error and most of the time no debug info. (yes sometimes briefly debug/status was displayed). I solved it partly by entering a port number in the network part of the add-on (used port 1880). after restarting. After wich I direct connect to node red <http://192,168.x.x:1880) logon with your home assistant password. When starting node-red inside home assistant no debug info...
This worked for me so this error must have something to do with the way Home Assistant/Node-Red is handling ingress.
I usually work on Node-Red remotely though via ingress and Nabu Casa so it is still a problem that needs a solution.
Is this happening in a specific browser?
I am not able to reproduce this at all (however, I am on dev)
I'm on Chrome, however everything randomly came back. I don't know how to reproduce it now either.
If it happens, is there anything in the browser console?
I'm getting
DevTools failed to load source map: Could not parse content for https://xxx.ui.nabu.casa/a0d7b954_nodered/gridstack.min.map: Unexpected token < in JSON at position 0
But the node statuses and debugging do end up popping up. So far I can't reproduce the same issue that I did have as they do populate within a few seconds now.
Edit: Also this as it's loading Node-Red, but it loads fine.
DevTools failed to load source map: Could not load content for https://xxx.ui.nabu.casa/api/hassio_ingress/r-xxx/vendor/purify.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
missing source maps is fine and would not be able to cause this.
I figured. If I'm able to reproduce I will post the console log.
I am getting this error now that I have been able to reproduce the issue:
Uncaught Error: cannot call methods on editableList prior to initialization; attempted to call method 'addItem'
at Function.error (vendor.js:2)
at HTMLOListElement.<anonymous> (vendor.js:10)
at Function.each (vendor.js:2)
at s.fn.init.each (vendor.js:2)
at s.fn.init.t.fn.<computed> [as editableList] (vendor.js:10)
at l (red.min.js:16)
at red.min.js:16
as well as
The main 'lit-element' module entrypoint is deprecated. Please update your imports to use the 'lit' package: 'lit' and 'lit/decorators.ts' or import from 'lit-element/lit-element.ts'.
but I'm not sure the second one is relevant at all.
This issue is happening pretty consistently for me again. I'm on the latest version of Home Assistant and the latest version of this add-on.
Here also
Add me to the list of effected
Running on a W10 VirtualBox Latest Version of everything Tried on Brave, Chrome, and Edge
Same here. After reboot of the system node statuses and debug info are gone.
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment š This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!
It's still an issue, I've just given up and now access Node-Red either via VPN or a personal subdomain.
Here also still problems
@MagicMountainMan If this:
Uncaught Error: cannot call methods on editableList prior to initialization; attempted to call method 'addItem'
at Function.error (vendor.js:2)
at HTMLOListElement.<anonymous> (vendor.js:10)
at Function.each (vendor.js:2)
at s.fn.init.each (vendor.js:2)
at s.fn.init.t.fn.<computed> [as editableList] (vendor.js:10)
at l (red.min.js:16)
at red.min.js:16
is the source/root cause of the issue, it isn't an add-on problem, but it originates from Node-RED itself (or might be induced by one of the Nodes). From an add-on perspective, there is nothing I can do or fix about that.
Add-ons provide a runtime for an application to run in/on. We don't create/maintain/change the application itself.
@frenck Fair enough, not a huge deal for me since I found other ways to easily access it, thanks for the help!
Is anybody else here experiencing extreme lags of the HA events:state nodes in conjunction with this debugging info problem? I see delayed reactions of these nodes of up to several 10 seconds after the original event happened. All other parts of the flows seem to work fast as usual.
Is anybody else here experiencing extreme lags of the HA events:state nodes in conjunction with this debugging info problem? I see delayed reactions of these nodes of up to several 10 seconds after the original event happened. All other parts of the flows seem to work fast as usual.
I see delays in every node, when i use the inject node, the flow starts inmediatly but in my browser there are delays of 20-30 seconds.
I had this problem, too. Somehow it went now away. I detected, that I had multiple "Server configurations" for the add-on. I wasn't specificly trying to get this solved, but wanted to do a bit cleaning in my node-red. After I deleted the multiple server entries and had only one remaining,configured as "using the HA-add-on" - not with a token, All went suddenly to normal. I have now debugging events again, the states are shown under the nodes which supports that. It is running for five days now and just to be sure I restarted HomeAssistant 3 times since then and the node-red add-on I think ten times or so. Used the palette to make upgrades of installed nodes and so on. Running on a ha-supervised install in a VM.
So I thought I share this here, maybe it helps someone or helps to find the root-cause of this odd behaviour.
What exactly do you mean by Ā«multiple "Server configurations" for the add-onĀ»? The Node Red add-on config in HA supervisor? Can't find any server settings there.
Problem/Motivation
All of a sudden all debug information disappeared! All the nodes seem to be working fine but they are not reporting anything within the node red web UI - neither in the right-hand side debug panel nor via status underneath each node.
Expected behavior
Actual behavior
No apparent trouble anywhere in the logs (e.g. core, supervisor), only these show up in the addon logs:
Steps to reproduce
Proposed changes
Home Assistant Community Store
GitHub API | ok -- | -- Github API Calls Remaining | 5000 Installed Version | 1.12.3 Stage | running Available Repositories | 890 Installed Repositories | 17AccuWeather
can_reach_server | ok -- | -- remaining_requests | 15Home Assistant Cloud
logged_in | false -- | -- can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | okHome Assistant Supervisor
host_os | Debian GNU/Linux 10 (buster) -- | -- update_channel | stable supervisor_version | supervisor-2021.04.3 docker_version | 20.10.6 disk_total | 108.1 GB disk_used | 33.9 GB healthy | true supported | true supervisor_api | ok version_api | ok installed_addons | Samba share (9.3.1), Duck DNS (1.12.5), NGINX Home Assistant SSL proxy (3.0.1), File editor (5.3.0), ESPHome (1.17.1), Mosquitto broker (5.1.1), Node-RED (9.1.1), Home Assistant Google Drive Backup (0.104.3), UniFi Controller (0.20.3), deCONZ (6.9.0), Network UPS Tools (0.7.0), Glances (0.12.1), Portainer (1.5.0), AdGuard Home (4.1.6), Visual Studio Code (3.3.1), iPerf3 (0.1.0), Frigate NVR (1.13), Terminal & SSH (9.1.2)Lovelace
dashboards | 1 -- | -- resources | 11 views | 13 mode | yamlSpotify
api_endpoint_reachable | ok -- | --