hassio-addons / addon-pi-hole

Pi-hole - Home Assistant Community Add-ons
https://addons.community
MIT License
123 stars 39 forks source link

404 error in recent queries #92

Closed bebach8 closed 4 years ago

bebach8 commented 5 years ago

Problem/Motivation

When in Pi Hole UI, in left menu you click "Network" and in clients list you click on device IP address to show recent queries by that device, it opens new browser tab and in that tab you get 404 error.

In new tab it opens it goes to address http://"hassio ip"/admin/queries.php?client="clicked device ip address" (without quotes) ex. 192.168.1.2

problem

addons-assistant[bot] commented 5 years ago

:wave: Thanks for opening your first issue here! If you're reporting a :bug: bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

sinclairpaul commented 5 years ago

Can you confirm if this is via ingress or with the web interface exposed, its hard to tell from the screenshot.

bebach8 commented 5 years ago

Just default "Show in sidebar". Ingress I think. ingress http://ip/a0d7b954_pi-hole

sinclairpaul commented 5 years ago

Can you retest when setting the network port for the UI and access via that. It looks like a Javascript issue that the client reads the URL, will confirm later but if thats the case it is unlikely to be fixed for Ingress.

bebach8 commented 5 years ago

Without ingress, port 12345

without ingress without ingress2

It says "File not found" error.

sinclairpaul commented 5 years ago

It is indeed a Javascript issue, https://github.com/pi-hole/AdminLTE/blob/44aff727e59d129e6201341caa1d74c8b2954bd2/scripts/pi-hole/js/network.js#L117

With the latest Ingress release, the admin interface was moved down a level, so the admin folder does not exist. May be able to fix this under the exposed addon, but unlikely under Ingress. For the time being you can load the page on the exposed addon by removing the /admin/ from the URI.

GitHub
pi-hole/AdminLTE
Pi-hole Dashboard for stats and more. Contribute to pi-hole/AdminLTE development by creating an account on GitHub.
addons-assistant[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

addons-assistant[bot] commented 4 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.