Closed Oniicode closed 7 months ago
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!
Problem/Motivation
Same as with the following issue librespot (as far as i understand this addon's base) used to have: https://github.com/librespot-org/librespot/issues/91 tl;dr: By default the listen port is randomized for understandable reasons. But if the listen port can't be set to something fixed, it's difficult to set up proper firewall rules in more hardened setups. Like allowing guest clients from the otherwise isolated guest vlan to connect.
Expected behavior
An optional field being present in the addon configuration section on the home assistant UI that allows to set the listen port, right next to the other options such as username etc. With an empty/zero value representing a randomized port.
Actual behavior
It's not present.
Proposed changes
Librespot has a way to set the port, by adding mentioned --zeroconf-port or -z cmdline arg. See https://github.com/librespot-org/librespot/pull/109
As far as I understand, there's some logic with the addons that allows maintainers to define fields visible on the configuration UI along with accepted values in some YAML. I'm sure those field values somehow can be passed through down to our call to the librespot binary, right?