hassio-addons / addon-unifi

UniFi Network Application - Home Assistant Community Add-ons

https://addons.community

MIT License

279 stars 138 forks source link

snapshot -> backup #264

Closed SNoof85 closed 3 years ago

SNoof85 commented 3 years ago

Proposed Changes

Rename snapshot to backup. See : https://developers.home-assistant.io/blog/2021/08/24/supervisor_update/

Related Issues

Fixes #263

FrankBurmo commented 3 years ago

Any progress here?

frenck commented 3 years ago

No, there is no progress here. This is a warning, not a bug. There is no hurry in getting this fixed. There are tons of other things to do that are more important at this point.

OneCyrus commented 3 years ago

this will break in 3 days -> https://github.com/home-assistant/core/pull/57652

SNoof85 commented 3 years ago

Nope that will break service call to snapshot but not addons config.

See : https://github.com/home-assistant/supervisor/blob/4416b6524eb120fc1456a305cf6dda49557c32cd/supervisor/addons/validate.py#L228

snapshot is still here :)

frenck commented 3 years ago

this will break in 3 days -> home-assistant/core#57652

That is incorrect, you mixing things up.