hassio-addons / addon-unifi

UniFi Network Application - Home Assistant Community Add-ons

https://addons.community

MIT License

279 stars 138 forks source link

[Enhancement] Sync addon to Unifi latest upstream versions #294

Closed rvincemt closed 3 years ago

rvincemt commented 3 years ago

Proposed Changes

Instead of modifying unifi controller version, this change makes sure that all deps are up-to-date, and downloads latest stable unifi controller deb from upstream.

Tested on local build on amd64, feel free to run on CI/Actions to see compatibility with arm64.

Related Issues

([Github link][autolink-references] to related issues or pull requests)

288

iMicknl commented 3 years ago

@rvincemt how would this work? I would be in favor of using the latest version as well, however I don't want to have it upgraded automatically, since Ubiquiti quality control can be better...

Perhaps we can have a simple GitHub Action that creates a new PR when there is a new version? Or will this solution make it easy to have the addon versioned.

rvincemt commented 3 years ago

@iMicknl, so the process is just like how most unifi-controller Docker images pull the latest version as well:

First it downloads the latest apt packages required for the controller to work.
Line 30 starts polling ubiquiti's stable branch for latest version, and then...
...passes it to line 44 for the build to download. Rest is just usual cleanup stuff.

I do agree though, I had several instances wherein my home network got messed up with latest update even on stable track. And yes, this PR can make it quite easier for the releases to be managed and versioned moving forward.

sinclairpaul commented 3 years ago

Would recommend you look at the workflows for the repo, particularly how images move between edge/beta/release.

Also how would you generate a changelog with this?

iMicknl commented 3 years ago

Also how would you generate a changelog with this?

My comment was also because of this concern. @rvincemt how would you do that?

Perhaps we can create a Github Action that will run and create a PR when a new stable version is ready? (similar to dependabot, but than for Unifi updates). This will allow maintainers to have a release gate and not automatically upgrade to the latest version, and will integrate with the current flow.