hassonlab / 247-encoding

Contains python scripts for performing encoding on 247 data.
0 stars 9 forks source link

Remove redundant function #46

Closed hvgazula closed 1 month ago

hvgazula commented 2 years ago

https://github.com/hassonlab/247-encoding/blob/03e73d281600e34e8a584025f0895b0e2aa93d69/scripts/tfsenc_read_datum.py#L95

Maybe consider moving to 247-pickling (what exactly is this function/column needed for).

hvgazula commented 2 years ago

https://github.com/hassonlab/247-pickling/blob/2fa1ef112ec80af92b5d78b2903daee130fb20ec/scripts/tfspkl_main.py#L30

Is this a duplicate of the above?

zkokaja commented 2 years ago

And remove https://github.com/hassonlab/247-encoding/blob/03e73d281600e34e8a584025f0895b0e2aa93d69/scripts/tfsenc_read_datum.py#L165

zkokaja commented 1 year ago

Remove function and call because conv_signal_length is not being used in encoding. But double check @hvgazula

zkokaja commented 1 year ago

Also look into whether we need the add_conv_onset/offset functions

VeritasJoker commented 1 year ago

Double-checked and deleted add_signal_length For add_convo_onset_and_offset, not sure if the columns are in pickling yet. Need to test with newest pickles

zkokaja commented 1 year ago

@hvgazula check pickling side for these columns

VeritasJoker commented 1 month ago

Resolved