search

hassonlab / 247-encoding

Contains python scripts for performing encoding on 247 data.
0 stars 9 forks source link

Dev #69

Closed VeritasJoker closed 1 year ago

VeritasJoker commented 1 year ago

Finally did the PR that I promised a month ago. Fixing most issues in encoding.

A few of the issues still need testing with the newest pickling code, others should be good to go

hvgazula commented 1 year ago

over to @zkokaja to approve and "merge" and not "rebase" into main

zkokaja commented 1 year ago

let's do a rebase again

hvgazula commented 1 year ago

are you really serious or just teasing us?

zkokaja commented 1 year ago

One comment: rand_emb and arb_emb functions should use a default seed and take it in as an argument. I'm okay with merging if we open a new issue for this

Nice to see documentation in the makefile on how to use the datum modifications!