search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

Dev #110

Closed hvgazula closed 1 year ago

hvgazula commented 1 year ago

Note that none of us can merge this until we get the 2 approved reviews. So, @VeritasJoker, you do the first review, followed by @zkokaja, who will then merge it. Sounds good?

hvgazula commented 1 year ago

The issues fixed in this PR can be seen in commit messages.

hvgazula commented 1 year ago

No, that will be a PR for next week. For now, we are merging as and when the issues are addressed. Think of this as the weekly PR. The answer to the second question is yes, of course.

Nice work! Can I ask two things. First, do we want to include the index changes in this pr or not (hassonlab/247-encoding#50)? Second, just to make sure, the reason we changed this is for static embeddings? Would it work for all models?

hvgazula commented 1 year ago

nice work..huh? are we working for the first time? :P. You are trying the sandwich approach.

VeritasJoker commented 1 year ago

nice work..huh? are we working for the first time? :P. You are trying the sandwich approach.

lol we can't even give compliments now? I'm just really impressed with the accelerator stuff. Besides I didn't say nice things at the end so at best this is an open sandwich : )

hvgazula commented 1 year ago

I agree. The accelerator part was pretty cool. Saves a lot of chopping and changing time.

hvgazula commented 1 year ago

Thank you sir.