search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

Makefile errors #25

Closed zkokaja closed 3 years ago

zkokaja commented 3 years ago

I have problems running makefile targets. In particular link-data fails with:

make: *** No rule to make target `link-data-vars', needed by `link-data'.  Stop.

And embeddings target depend on non-existing targets such as generate-embeddings-variables and generate-embeddings-vars. For example, https://github.com/hassonlab/247-pickling/blob/main/Makefile#L81

hvgazula commented 3 years ago

Please remove all dependent targets and it should work fine. Lmk if it doesn't.

hvgazula commented 3 years ago

Please pull the new commit and let me know how it goes. Thanks.

hvgazula commented 3 years ago

@zkokaja Were you able to run the link-data target? I am running into permission errors now. Were the permission on /projects changed?

Screen Shot 2021-04-09 at 11 47 27 AM
zkokaja commented 3 years ago

Thanks, I'll test and let you know. I haven't changed any permissions.

hvgazula commented 3 years ago

Resolved

zkokaja commented 3 years ago

One additional problem: https://github.com/hassonlab/247-pickling/blob/main/Makefile#L8 should have no space after last character and the first comment hashtag, because this happens:

ln -sf /projects/HASSON/247/data/conversations-car/* data/tfs /

It tries to link everything to /.

hvgazula commented 3 years ago

Sorry, I forgot to push the changes :). Please check the new commit https://github.com/hassonlab/247-pickling/tree/658bc3ad4821d884a5f0cc3034f7fce5d35e31b6 and close the issue if it works fine.