search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

Layer generation all layers 247 #38

Closed zkokaja closed 2 years ago

zkokaja commented 2 years ago

https://github.com/hassonlab/247-pickling/blob/96cfc2fb92643a3ab092ba5a65d36a77f05faa72/code/tfsemb_main.py#L339

Need to implement this. final_embeddings is a list of dicts of layer: embeddings items. It works for one conversation but if running multiple they need to be merged.

zkokaja commented 2 years ago

Talked with Harsha. We agreed we don't need the for loop (here https://github.com/hassonlab/247-pickling/blob/main/code/tfsemb_main.py#L318) at all because we only generate embeddings one conversation at a time, so this issue I raised won't be encountered. The fix for this would be to remove and clean up the loop.