search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

copy-embeddings make target vs python script #50

Closed hvgazula closed 1 year ago

hvgazula commented 2 years ago

If the copy-embeddings target replaces the tfspkl_copy.py, then I reckon we should just delete the python script. Also, probably ln -s is better instead of cp to save space. What do you think @zkokaja?

zkokaja commented 2 years ago

Good idea! How would it affect uploading to gcp? Either way it seems it can be in bash instead of python

hvgazula commented 2 years ago

indeed. Also, I don't see it affecting gs rsync.

zkokaja commented 1 year ago

@zkokaja what can be done?

hvgazula commented 1 year ago

deleted tfspkl_copy.py as the make target 'copy-embeddings' takes care of it