search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

Is 'generate_embeddings' a redundant function? #52

Closed hvgazula closed 2 years ago

hvgazula commented 2 years ago

@zkokaja @VeritasJoker Any idea why we have this function? Looking at this part of the main function, it looks like we have function calls for glove, blenderbot, and all other causalLM models. So, I think the aforementioned function is redundant? Please clarify.

hvgazula commented 2 years ago

Likewise args.history feels redundant now? What do you think?

hvgazula commented 2 years ago

comments?

VeritasJoker commented 2 years ago

I don't think I see the function used anywhere, so yeah seems like it

hvgazula commented 2 years ago

https://github.com/hassonlab/247-pickling/commit/378447b2c21572b839889377498581123496fd83