search

hassonlab / 247-pickling

Contains code to create pickles from raw/processed data
1 stars 9 forks source link

small fixs for generating and concatenating embeddings #63

Closed miahong closed 2 years ago

VeritasJoker commented 2 years ago

Hey Mia, add these two lines to tfsemb_concat.py, after line 78: if '/' in stra: stra = args.embedding_type.split("/")[-1]

This should solve the problem where slash creates folders. Then we don't need to modify the EMB_TYPE argument in the Makefile @miahong

miahong commented 2 years ago

that works! thanks!

hvgazula commented 2 years ago

closed because the changes have been made manually. But thanks for your work on this part of the code.

VeritasJoker commented 2 years ago

I couldn't find the original comment @hvgazula but I'm fine either way. As long as the pickles we generated only has the last part of the model name we should be fine