search

hassox / phoenix_guardian

A demo application showing usage of guardian and ueberauth
MIT License
299 stars 70 forks source link

Update example to latest Guardian, Phoenix and Guardian_db versions #3

Closed Pjino closed 8 years ago

Pjino commented 9 years ago

Just to make sure everything is OK without the need of tweaking things.

Donwangugi commented 9 years ago

Bump :)

Pjino commented 9 years ago

@Donwangugi Thanks!

doomspork commented 9 years ago

The best outcome for this is if someone puts in the work and opens a PR. That said I pulled the project, bumped the dependency versions, and a whole slew of things broke. I'm going to try updating the project for Phoenix 1.0 and Guardian 6.2 but it's further down on my list of things to do.

doomspork commented 9 years ago

@Pjino and @Donwangugi see PR #5 for updated dependencies and tests. Thoughts/feedback always appreciated :grinning:

Pjino commented 9 years ago

@doomspork . Thanks a lot. I must confess that I'm not (yet) of great help because I'm in my first steps in software development/Github and I don't know how to access your changes (I still see the latest commit in 23rd August...)

doomspork commented 9 years ago

Good morning @Pjino, that is no problem!

I opened a Pull Request for my changes so you can start there. If you click here and then "Files Changed" you'll see the modifications I needed to make. To see my changes in their entirety you can peek at my fork, specifically the branch "update_dependencies", found here.

Hope that helps :grinning:

hassox commented 8 years ago

I've updated the app and changed it's default branch. It was a full re-generate.