search

hastexo / markdown-xblock

An Open edX XBlock allowing course authors to maintain content exclusively in Markdown
GNU Affero General Public License v3.0
7 stars 8 forks source link

A working markdown XBlock #1

Closed arbrandes closed 8 years ago

fghaas commented 8 years ago

OK, so that all looks good functionally. About the naming: I take it no-one thought to devise a proper module namespace when they came up with the XBlock concept, correct? So the XBlock modules are all actually expected to be named "foobar", rather than something like "edx.xblock.foobar" — which is begging for naming conflicts with existing Python modules?

arbrandes commented 8 years ago

Correct, as far as I can tell from all XBlocks I've seen, and from the docs. No namespacing whatsoever, which sucks bigtime.

fghaas commented 8 years ago

Where's my surprised face?

fghaas commented 8 years ago

Wasn't there still some renaming of markdown to mdown pending in some of the CSS?

arbrandes commented 8 years ago

You mean this?

https://github.com/hastexo/markdown-xblock/blob/master/mdown/templates/main.html#L1

Sure, I can change that to "mdown_block".

fghaas commented 8 years ago

Yes, that one.

arbrandes commented 8 years ago

@fghaas, addressed on ac5983c.