hastexo / olx-utils

Tools facilitating the creation of Open edX courseware in the Open Learning XML (OLX) format
GNU Affero General Public License v3.0
5 stars 5 forks source link

Refactor the CLI, part 3 #29

Closed fghaas closed 5 years ago

fghaas commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #29 into master will increase coverage by 11.29%. The diff coverage is 96.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #29       +/-   ##
===========================================
+ Coverage   87.03%   98.33%   +11.29%     
===========================================
  Files           6        8        +2     
  Lines         324      481      +157     
===========================================
+ Hits          282      473      +191     
+ Misses         42        8       -34
Impacted Files Coverage Δ
tests/test_cli.py 100% <100%> (ø) :arrow_up:
olxutils/git.py 100% <100%> (ø)
olxutils/templates.py 100% <100%> (ø) :arrow_up:
tests/test_full_course.py 100% <100%> (ø) :arrow_up:
tests/test_helpers.py 100% <100%> (ø) :arrow_up:
olxutils/cli.py 95.12% <88.88%> (+27.12%) :arrow_up:
tests/test_git.py 95.29% <95.29%> (ø)
olxutils/helpers.py 100% <0%> (+26.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa44ad2...887f683. Read the comment docs.

fghaas commented 5 years ago

Alrighty, then we went from 30% to 90+% test coverage in a week. Doesn't suck. :)

fghaas commented 5 years ago

Thanks for reviewing!