search

hastexo / tutor-contrib-retirement

This is an experimental Tutor plugin. You should not consider it ready for production use at this point.
GNU Affero General Public License v3.0
2 stars 7 forks source link

Prepare 0.0.1 release #11

Closed fghaas closed 2 years ago

fghaas commented 2 years ago

I think at this point we are ready for a first tagged release, so unless you're aware of anything that we still absolutely need to include for this to be useful, here's a PR for 0.0.1.

foadlind commented 2 years ago

The only thing I can think of is the ability to add more entries for the retirement_pipeline in the pipeline config file. I haven't looked at how we can do that with Tutor config parameters yet. Also we probably need to add more Open edX services to the base_url part of the pipeline config file. Should we do those in this release or later?

foadlind commented 2 years ago

Here you can see an example with more services in the pipeline config file.

fghaas commented 2 years ago

Here you can see an example with more services in the pipeline config file.

Ok that looks like a relatively simple exercise to check {% if ECOMMERCE_HOST is defined %} (it would only be defined if the ecommerce plugin is enabled), and to add the appropriate entries to config.yml if set.

As for the credentials service, as of last year, nobody had yet written a Tutor plugin, so we probably have to exclude that. It doesn't hurt if we mention it in the README though.

Can you prepare a PR for that? I'll meanwhile mark this one as a draft, and will rebase it once your PR lands.

foadlind commented 2 years ago

Ack

foadlind commented 2 years ago

PR #12 adds more services to the pipeline configuration.