search

hastic-zzz / hastic-grafana-app

Hastic data management server for labeling patterns and anomalies in Grafana
https://hastic.io
GNU General Public License v3.0
179 stars 18 forks source link

TypeError: Cannot read property 'isUp' of undefined #398

Closed amper43 closed 4 years ago

amper43 commented 4 years ago

User gets the following error if hastic-datasource isn't selected because of deletion of analyticService https://github.com/hastic/hastic-grafana-app/blob/master/src/panel/graph_panel/graph_ctrl.ts#L316

Uncaught (in promise) TypeError: Cannot read property 'isUp' of undefined
    at GraphCtrl.eval (graph_ctrl.ts:335)
    at step (data_processor.ts:219)
    at Object.eval [as next] (data_processor.ts:219)
    at fulfilled (data_processor.ts:219)
jonyrock-back commented 4 years ago

It's really bad. Steps to reproduce:

  1. Create a new dashboard
  2. Enter your metric
  3. .... get the error

you just need NOT TO select hastic datasource.

it's very confusing. I think we should show a error something like "select hastic datasource"