search

hastic-zzz / hastic-grafana-app

Hastic data management server for labeling patterns and anomalies in Grafana
https://hastic.io
GNU General Public License v3.0
179 stars 18 forks source link

Unavailable analytic units in Grafana v7.1.3 #450

Closed cgrigel closed 3 years ago

cgrigel commented 4 years ago

Dear Hastic team,

The "+Add Analytic Unit" button not available in Grafana v7.1.3 (5723d951af) UI.

Capture

Thank you in advance for your cooperation and feedback.

rjvtww commented 3 years ago

Any updates on this? I am eagerly waiting for the fix!

rozetko commented 3 years ago

Hey @cgrigel @rjvtww @nikitag55, fixes are merged into master. It's possible to run the plugin from source if you want to test it

spliakos commented 3 years ago

I have installed on containers/kubernetes the server and analytics apps, plus downloaded the new grafana-app plugin versioon 0.4.0. I guess when you said that fixed are merged into master, you were referring to the new tag rozetko (?)... Nope, this doesn't seem to work. I have Grafana 7.1.3 and grafana-app and server 0.4.0. I get succesful connection from the Grafana plugin to the datasource. However, just like cgrigel I don't see any analytic units!

rozetko commented 3 years ago

Hey @spliakos, the fix is not released so it doesn't have a tag yet It's currently available only from source: https://github.com/hastic/hastic-grafana-app/wiki/Development#install-from-source

spliakos commented 3 years ago

Hey @rozetko, thanks for the clarification. I'll try to install from source just to play a bit with it and wait for next release. Mind you, I upgraded to grafana 7.2.0 with 0.4.0 versions for grafana-plugin and server, but still I can't see any add analytic unit button.

markuman commented 3 years ago

I'm on grafana 7.2.0 using hastic 0.5.0 and I see

runRequest.catchError TypeError: e is undefined
    M runRequest.ts:107
    RxJS 3
runRequest.ts:119:14
    M runRequest.ts:119
    RxJS 4

Screenshot_2020-10-16 New dashboard Copy - Grafana

markuman commented 3 years ago

Ok Ok, I'm a hastic noob.

Screenshot_2020-10-16 New dashboard Copy - Grafana(1)

markuman commented 3 years ago

Screenshot_2020-10-16 New dashboard Copy - Grafana(2)

Ok I got it work. But not with Grafana 7.2.1. Only with Grafana 7.1.3

jonyrock commented 3 years ago

@markuman thank you for the report, we will try to improve the UX

rozetko commented 3 years ago

Hi @markuman, what is the problem with Grafana 7.2.1? Can you please create a separate issue?

rozetko commented 3 years ago

Fixes for this issue are released in 0.5.0 version: https://github.com/hastic/hastic-grafana-app/releases/tag/0.5.0

jonyrock commented 3 years ago

@rozetko but do we have understanding about how are we going to improve the UI?

rozetko commented 3 years ago

@jonyrock not yet, waiting for @markuman to create a separate issue

markuman commented 3 years ago

I'm not sure if it's the design or if it's the quality of the documentation.

jonyrock commented 3 years ago

@markuman your help will be very appreciated if you can help us with the docs :factory_worker:

markuman commented 3 years ago

For the beginning it would be nice to have a flow chart to see single parts and how they interact with each other.
Mermaid would be nice, but sadly github does not support it.
So it must be drawed with something alse ...draw.io maybe.

You need

where hastic server communicates with grafana using env variable GRAFANA_URL. Furthermore it requires an API Key from grafana, but the env variable is named HASTIC_API_KEY. That's confusing. GRAFANA_API_KEY would be a better name.

the analytics server is communicating with hastic server. It's controllable using env variable HASTIC_SERVER_URL (which must be a websocket url)

I got this information after reading the docker compose files. Not everyone is using docker compose. Once it is documentated in general, most people should be able to transform it to their container orchestration (k8s, docker swarm mode, ecs etc) and maybe can also contribute it.

I rolled it out using ansible