ERROR: Property 'length' is missing in type 'AnalyticMeta' #823 - Githubissues

hastic-zzz / hastic-server

Hastic data management server for analyzing patterns and anomalies from Grafana

GNU General Public License v3.0

330 stars 23 forks source link

ERROR: Property 'length' is missing in type 'AnalyticMeta' #823 #822

Closed VargBurz closed 4 years ago

VargBurz commented 4 years ago

This PR fixes #823

Probem:

We pass the argument with nested objects to querystring.stringify, but it supports only simple types: see querystring.stringify documentation

Solution:

Get rid of application/x-www-form-urlencoded webhook content type because:

we don't support it properly
it's not clear how to add nested object to a querystring

Changes:

remove HASTIC_WEBHOOK_TYPE and HASTIC_WEBHOOK_SECRET config variables
use only JSON data format in sendNotification method