search

hastic-zzz / hastic-server

Hastic data management server for analyzing patterns and anomalies from Grafana
GNU General Public License v3.0
330 stars 23 forks source link

unfriendly crash with missing HASTIC_API_KEY #899

Closed jonyrock closed 4 years ago

jonyrock commented 4 years ago

why do we crash like this:

            throw new Error(`Please configure ${field}`);
            ^

Error: Please configure HASTIC_API_KEY
    at getConfigField (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:164:19)
    at Object../src/config.ts (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:125:26)
    at __webpack_require__ (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:20:30)
    at Object../src/services/data_layer/index.ts (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:3185:18)
    at __webpack_require__ (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:20:30)
    at Object../src/services/data_service/index.ts (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:3895:22)
    at __webpack_require__ (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:20:30)
    at Object../src/models/analytic_unit_cache_model.ts (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:994:24)
    at __webpack_require__ (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:20:30)
    at Object../src/controllers/analytics_controller.ts (/home/corp/temp_projects/hastic/hastic-server/server/dist/server-dev.js:268:27)
hastic-server crashed

when we can just show an error and exit without crashing