hastic-server docker redundant git

hastic-zzz / hastic-server

Hastic data management server for analyzing patterns and anomalies from Grafana

GNU General Public License v3.0

330 stars 23 forks source link

hastic-server docker redundant git #907

Open jonyrock opened 4 years ago

jonyrock commented 4 years ago

FROM node:8-alpine AS build

RUN apk add --no-cache git

# Note: context starts in the directory above (see docker-compose file)
COPY .git /var/www/.git
COPY server /var/www/server

We already have a webpack-building-stage-git-info and it should be enough. @rozetko what do you think

rozetko commented 4 years ago

This part of Dockerfile is build stage. It's specified in the 1st line. This is what we do in this stage:

copy all the necessary files from the repo to container (including .git)
build server
keep the artifacts (dist/) for the next stage

Everything else is removed as soon as the Docker image is built

jonyrock commented 4 years ago

so we decided with @rozetko internally that we will extract necessary from build variables like we do in webpack.

jonyrock commented 4 years ago

btw, it's a bit related https://github.com/hastic/hastic-server/issues/910