search

hasu / notdeft

NotDeft note manager for Emacs
https://tero.hasu.is/notdeft/
170 stars 14 forks source link

translate filter-increment input chars using current input method #25

Closed intramurz closed 2 years ago

intramurz commented 2 years ago

The incremental filter, as it is, ignores the current input method, so when we toggle-input-method to a non-ASCII one (for example, Cyrillic or Greek), only the corresponding ASCII characters still appear in the filter input line. The problem also exists in the original "deft" package too. This small fix resolves the issue. It works well for "Russian" input method, but should also work for other similar input methods using quail minor mode.

Thank you for your wonderful package. Good luck to you.

hasu commented 2 years ago

Thank you for the contribution. I've merged your changes.

I noticed that input-method-function could also return nil, and so I made a follow-up change to guard against that, and to even accept multiple returned characters.