More cleanups

[zx2c4]

Automatically getting the list of all repos is particularly nice in this series.

[hasufell]

I personally am not sure this is a good idea. I have done something similar for myself in paludis, but I'm not sure if that is a good default. I'd rather add a comment like:

# add your overlays here (name of the overlay!)
# overlay_list=( )

# if you want to update cache for all overlays, uncomment the following line
# overlay_list=( $(portageq get_repos / | sed 's#\(^\| \)gentoo\( \|$\)##') )

[zx2c4]

I disagree. I think doing it for all repos is indeed a sensible default. There is never any harm in generating the cache, and it only helps speed things up, since all emerge operations wind up using it. If users have very odd particular desires to disable generation of the cache, then they can make some modifications. Requiring users to edit the script for ordinary functionality seems a bit baroque.

I made your suggested change of portageq; thanks for that.

[hasufell]

Requiring users to edit the script for ordinary functionality seems a bit baroque.

That's called configuration.

Anyway, I'd be fine to make it

# If you don't want to update cache for all overlays, comment the following line or
# adjust it to your needs.
overlay_list=( $(portageq get_repos / | sed 's#\(^\| \)gentoo\( \|$\)##') )

but there is no good reason to remove that variable altogether.

[hasufell]

Or probably better:

# by default syncs all available repositories
repository_list= ( $(portageq get_repos /) )

[hasufell]

only added the first commit