hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

nitpicks in test your jwt section #549

Closed rikinsk closed 1 month ago

rikinsk commented 2 months ago

Description

fixes to test your jwt section

Quick Links 🚀

🤖 DX: Assertion Tests

robertjdominguez commented 2 months ago

Hey, @rikinsk :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Sean as your reviewer :tada:

Before Sean looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Sean know the level of urgency on Slack :+1:

robertjdominguez commented 2 months ago

DX: Assertion Testing

✅ Diff

The diff shows good improvements in terms of grammar, clarity, and correctness. Fixing the 'setup' to 'set up' aids in readability, updating the JWT claims location to a more user-friendly path helps clarity, and ensuring punctuations are consistent contributes to better readability and structure. Great attention to detail in catching these small yet impactful changes.

✅ Integrated

The updated diff integrates seamlessly into the existing documentation. The changes are consistent with the overall style and conventions used throughout the document. The updated path for JWT claims aligns with best practices of using standard URIs and makes sense within the context. Correcting grammatical issues and consistent punctuation usage throughout the document further enhances the usability of the documentation. The latest PR maintains the informative and instructive language style, thus meeting the usability assertion criteria.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84a73a4
Status: ✅  Deploy successful!
Preview URL: https://a22180b5.v3-docs-eny.pages.dev
Branch Preview URL: https://rikinsk-update-try-jwt-secti.v3-docs-eny.pages.dev

View logs