hasura / ddn-docs

Repository for the Hasura DDN version of docs

https://hasura.io/docs

2 stars 6 forks source link

fix sed in postgres docs #553

Closed soupi closed 2 months ago

soupi commented 2 months ago

Description

I made a mistake with the sed command in https://github.com/hasura/v3-docs/pull/550. This fixes it.

Quick Links 🚀

🤖 DX: Assertion Tests

robertjdominguez commented 2 months ago

Redirects 🔀

Hey, @robertjdominguez & @seanparkross — the following redirects will be needed for deployment:

# TEST ME: https://stage.hasura.io/docs/3.0/getting-started/build/_databaseDocs/_postgreSQL/_08-mutate-data/
location = /docs/3.0/getting-started/build/_databaseDocs/_postgreSQL/_08-mutate-data/ {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}

robertjdominguez commented 2 months ago

Hey, @soupi :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Sean as your reviewer :tada:

Before Sean looks over the changes, we ask you to take care of a couple of items:

[ ] Make sure you've checked over our PR guide on the wiki. It ensures you've done your due diligence on the basics: spelling, heading casings, etc.
[ ] Sean will need a review from someone on your team to ensure your team-specific content is accurate. Once that's done, ping Sean on Slack, and he'll give a docs review :fire:
[ ] Additionally, please check this box to confirm your feature works as expected when using the documentation you've written. This is critical to ensuring our users have the information they need.

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Sean know the level of urgency on Slack :+1:

robertjdominguez commented 2 months ago

DX: Assertion Testing

✅ Diff

The correction made to the JSON snippet correctly adjusts for proper JSON syntax by adding a colon ':' instead of the erroneous equals sign '=' in the original text. This is important for users to successfully modify their configuration files.

✅ Integrated

The corrected command fits seamlessly into the existing step-by-step process of enabling auto-generated mutations. It enhances the usability of the documentation by ensuring that the technical instructions will work correctly when executed by the user. The change does not disrupt the flow or structure of the overall documentation and remains consistent with the task's intent.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying v3-docs with Cloudflare Pages

Latest commit:	`851572b`
Status:	✅ Deploy successful!
Preview URL:	https://822a0340.v3-docs-eny.pages.dev
Branch Preview URL:	https://gil-fix-sed.v3-docs-eny.pages.dev

View logs