hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

Fix typo in 02-create-source-metadata.mdx #570

Closed daniel-chambers closed 1 month ago

daniel-chambers commented 1 month ago

Description 📝

Fixes a trivial typo on the update data source metadata page.

Quick Links 🚀

https://daniel-fix-typo.v3-docs-eny.pages.dev/getting-started/build/connect-to-data/create-source-metadata#step-2-update-or-add-models

Assertion Tests 🤖

robertjdominguez commented 1 month ago

DX: Assertion Testing

✅ Diff

The typo in the command has been corrected from 'connetor-name' to 'connector-name', which is crucial for avoiding confusion and potential errors when users copy and paste the command.

❌ Integrated

While the typo correction is valuable, it appears that the terminology across the document is inconsistent; 'hml' files are mentioned, which may be intended to be 'html' or another file type. Additionally, the description of squeezing numerous model updates in 'en masse' lacks details on how conflicts or errors are handled, which could be critical for users working with large datasets.

robertjdominguez commented 1 month ago

Hey, @daniel-chambers :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer :tada:

Before Rob looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack :+1:

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a40fbd
Status: ✅  Deploy successful!
Preview URL: https://15641e50.v3-docs-eny.pages.dev
Branch Preview URL: https://daniel-fix-typo.v3-docs-eny.pages.dev

View logs