hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

Fix Thumbnail component #578

Closed robertjdominguez closed 1 month ago

robertjdominguez commented 1 month ago

Description 📝

Fixes thumbnail component so that, when a user clicks on an image, the modal enlarges it to a readable size.

It looks like the root cause of this was the translation from SCSS to CSS when migrating to DDN docs. So, this was solved by primarily just cleaning up the style rules and classnames.

Before image

After image

Quick Links 🚀

Example on Explore your API

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35aaa7b
Status: ✅  Deploy successful!
Preview URL: https://6bad36be.v3-docs-eny.pages.dev
Branch Preview URL: https://rob-fix-thumbnail-component.v3-docs-eny.pages.dev

View logs

robertjdominguez commented 1 month ago

Hey, @robertjdominguez :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer :tada:

Before Rob looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack :+1: