hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

Quickstart with postgres should not do command add #582

Closed nullxone closed 1 month ago

nullxone commented 1 month ago

Description 📝

Quickstart uses a postgres database which does not have any commands.

Doing command add shows a slightly scary error message telling the users that there are no commands.

The disadvantage is that we no longer introduce the primitive in the quickstart. Instead, we should introduce command add elsewhere.

Quick Links 🚀

Assertion Tests 🤖

robertjdominguez commented 1 month ago

DX: Assertion Testing

✅ Diff

The changes simplify the command sequence which helps the user avoid unnecessary steps and streamlines the quickstart process.

❌ Integrated

The removal of the 'ddn command add my_connector '*' command may affect subsequent sections that assume the user has added commands for their connector. Ensure that the removal of this step does not impact any dependent steps or explanations further in the documentation, and update them accordingly if needed.

robertjdominguez commented 1 month ago

Hey, @nullxone :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer :tada:

Before Rob looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack :+1:

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: bfec643
Status: ✅  Deploy successful!
Preview URL: https://8ee32f17.v3-docs-eny.pages.dev
Branch Preview URL: https://ak-docs-quickstart-no-comman.v3-docs-eny.pages.dev

View logs