hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

Docs: Nitpick upgrades #584

Closed robertjdominguez closed 1 month ago

robertjdominguez commented 1 month ago

Description 📝

Nitpicks the new upgrade section with a few pieces of feedback. Yes, we can be meaner to Hasura v2 now 🤷

Quick Links 🚀

Upgrade section

Assertion Tests 🤖

A v2 use should understand why DDN is a better choice.

robertjdominguez commented 1 month ago

Hey, @robertjdominguez :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer :tada:

Before Rob looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack :+1:

robertjdominguez commented 1 month ago

DX: Assertion Testing

✅ Diff

The PR effectively clarifies various upgrade strategies from Hasura v2 to Hasura DDN. The content is neatly organized, and consistent formatting is maintained throughout the document. The inclusion of headers for different strategies, as well as the visual diagrams, are helpful. Additionally, it appears you have addressed prior limitations within the document by updating the section on 'GraphQL Connector Limitations.' Good work on keeping the language user-friendly and on providing actionable steps for users to follow.

✅ Integrated

The PR provides a comprehensive guide that integrates smoothly with the current documentation. The restructuring adds clarity and improves the narrative, helping users understand the migration process better. The document is more accessible and coherent, significantly contributing to the overall usability. It continues to provide the necessary context and establishes a clear pathway for users considering upgrading to DDN. The updated sections align well with the existing content, maintaining a consistent voice and style. The usability assertion is met, as users can now better understand the advantages of migrating to DDN.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f0847c9
Status:⚡️  Build in progress...

View logs