hasura / ddn-docs

Repository for the Hasura DDN version of docs
https://hasura.io/docs
2 stars 6 forks source link

Add reference in the Postgres docs to mention the certificate environment variables. #597

Closed i-am-tom closed 1 month ago

i-am-tom commented 1 month ago

Description 📝

Hopefully not too controversial: this adds a paragraph to the Postgres documentation to note which environment variables can be used to configure SSL certificates.

Quick Links 🚀

Assertion Tests 🤖

A user should be able to discover the environment variables involved in configuring SSL certificates.

hasura-bot commented 1 month ago

DX: Assertion Testing

✅ Diff

The PR does a good job in clearly explaining how to configure SSL by using environment variables. The added example is helpful for users to understand how to set the variable from a file.

✅ Integrated

The PR integrates well with the existing documentation. The addition of SSL configuration info under the 'Configuration workflows' section is consistent with the purpose of the document, which is to provide a comprehensive guide to setting up the PostgreSQL connector.

hasura-bot commented 1 month ago

Hey, @i-am-tom :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer :tada:

Before Rob looks over the changes, we ask you to take care of a couple of items:

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack :+1:

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c42360b
Status: ✅  Deploy successful!
Preview URL: https://c6e5fdca.v3-docs-eny.pages.dev
Branch Preview URL: https://i-am-tom-mention-env-vars.v3-docs-eny.pages.dev

View logs