Closed paritosh-08 closed 1 month ago
[https://hasurahq.slack.com/archives/C06P2U8U55G/p1726170627499649](https://hasurahq.slack.com/archives/C06P2U8U55G/p1726170627499649)
Hey, @paritosh-08 :wave:
Thanks for this PR! Since you changed docs files, our automated Action assigned Sean as your reviewer :tada:
Before Sean looks over the changes, we ask you to take care of a couple of items:
The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Sean know the level of urgency on Slack :+1:
The PR updates terminology consistently (e.g., 'cloudflare allow list' to 'cloudflare allowlist'), improves session and rawRequest config object declarations (replacing LeafConfig with {}
), and adds valuable visual context with the 'Architecture' section including an image. However, there's a typo in the 'quickstart.mdx' file: 'Wranlger' should be corrected to 'Wrangler'. Also, ensure that the 'hasura-m-auth' key is properly safeguarded if it's sensitive.
Integration of the new sections and fixes appears to be seamless with the overall documentation structure. The new subsection 'Pre-Parse Plugin Request' with a sample request adds practical guidance on how a plugin configuration translates into an actual request. The restructuring of the quickstart guide streamlines the setup process. The addition of the local testing steps in 'quickstart.mdx' (Step 2 to Step 5) and the graphical representation of the architecture in 'introduction.mdx' augment the usability by making the setup and test process clearer for the user. Make sure the image file 'architecture.jpg' is correctly checked into the repository with the right path specified.
Images automagically compressed by Calibre's image-actions β¨
Compression reduced images by 26.1%, saving 17.48 KB.
Filename | Before | After | Improvement | Visual comparison |
---|---|---|---|---|
static/img/plugins/architecture.jpg |
66.89 KB | 49.41 KB | -26.1% | View diff |
177 images did not require optimisation.
Latest commit: |
a92e8e6
|
Status: | β Deploy successful! |
Preview URL: | https://8b72fa63.v3-docs-eny.pages.dev |
Branch Preview URL: | https://paritosh-apipg-890.v3-docs-eny.pages.dev |
Q: What is m-auth?
Hi @rahulagarwal13
As chatted to @paritosh-08 about...
This new repo https://github.com/hasura/plugin-allowlist
Should we name it engine-plugin-allowlist
so that we donβt confuse CLI and engine plugins down the line?
Itβs new so I thought Iβd bring it up now to hopefully catch it while we can.
Q: What is m-auth?
M-auth stands for mutual authentication. The engine will send a random (pre-selected) string in the header, which will be checked by the plugin server to allow/disallow the request.
Q: What is m-auth?
M-auth stands for mutual authentication. The engine will send a random (pre-selected) string in the header, which will be checked by the plugin server to allow/disallow the request.
Nice! Can we document this? Maybe for now just an admonition in this (engine plugins) section?
:) Will approve as soon as you've added that π
Hi @rahulagarwal13 As chatted to @paritosh-08 about... This new repo https://github.com/hasura/plugin-allowlist Should we name it
engine-plugin-allowlist
so that we donβt confuse CLI and engine plugins down the line? Itβs new so I thought Iβd bring it up now to hopefully catch it while we can.
@seanparkross - nice catch! yes let's make it explicit. I am fine with changing the repo name to "engine-plugin-"
Description π
This PR updates the docs for engine plugins.
LeafConfig
from the metadata ref page.Quick Links π
Assertion Tests π€