fix typo in project v3 upgrade guide

rikinsk commented 1 month ago

Description 📝

remove trailing text in docker file in project v3 upgrade guide

Quick Links 🚀

Assertion Tests 🤖

hasura-bot commented 1 month ago

Hey, @rikinsk :wave:

Thanks for this PR! Since you changed docs files, our automated Action assigned Sean as your reviewer :tada:

Before Sean looks over the changes, we ask you to take care of a couple of items:

[ ] Make sure you've checked over our PR guide on the wiki. It ensures you've done your due diligence on the basics: spelling, heading casings, etc.
[ ] Sean will need a review from someone on your team to ensure your team-specific content is accurate. Once that's done, ping Sean on Slack, and he'll give a docs review :fire:
[ ] Additionally, please check this box to confirm your feature works as expected when using the documentation you've written. This is critical to ensuring our users have the information they need.

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Sean know the level of urgency on Slack :+1:

hasura-bot commented 1 month ago

DX: Assertion Testing

❌ Diff

The modification in the 'develop' section's 'watch' key seems to remove a critical piece of a sentence without adding any substantial or clarifying information. It appears incomplete and requires additional context or reversion to the original state for coherence.

❌ Integrated

The PR's diff removes a line that seems to provide context on where the 'watch' configuration is applicable, particularly mentioning a shared supergraph config file. This removal could lead to confusion, as users might miss the importance of different configurations for shared versus non-shared supergraph environments. The update should maintain clarity on different use cases for the 'watch' configuration within the bigger context of the documentation.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying v3-docs with Cloudflare Pages

Latest commit:	`1015e0a`
Status:	✅ Deploy successful!
Preview URL:	https://60dea2e6.v3-docs-eny.pages.dev
Branch Preview URL:	https://rikinsk-fix-typo-in-upgrade.v3-docs-eny.pages.dev

View logs

hasura / ddn-docs