search

hasura / gitkube

Build and deploy docker images to Kubernetes using git push
Apache License 2.0
3.81k stars 208 forks source link

support for .dockerconfigjson #45

Closed tirumaraiselvan closed 6 years ago

0x777 commented 6 years ago

Do we need the credentials to have a secretKeyRef? Why can't it be secretName? The controller can then check if the secret's type is one of kubernetes.io/dockercfg or kubernetes.io/dockerconfigjson and act accordingly?

tirumaraiselvan commented 6 years ago

Sounds good but this would be a breaking change. This would change the spec of remote.yaml which means we probably need v1alpha2 group or something?

I think we should go ahead with this for v1alpha1 and make the required changes in v1alpha2

shahidhk commented 6 years ago

You can create a new key called secretName and it will not breadk existing config

0x777 commented 6 years ago

Either we can go with @shahidhk's suggestion and add this as a non breaking change or bump the version to v1alpha2 and document the changes.

tirumaraiselvan commented 6 years ago

Added secretRef to point to a secret