search

hasura / gitkube

Build and deploy docker images to Kubernetes using git push
Apache License 2.0
3.81k stars 207 forks source link

fix #78, handle permissions for docker.sock in a better way #82

Closed shahidhk closed 6 years ago

shahidhk commented 6 years ago

@tirumaraiselvan This PR fixes #78. But, while testing some other issue with certain parameters in sshd_config being deprecated has appeared. Please check once before merging.

The following lines appear continuously with different port numbers in the logs for gitkubed:

rexec line 19: Deprecated option KeyRegenerationInterval
rexec line 20: Deprecated option ServerKeyBits
rexec line 31: Deprecated option RSAAuthentication
rexec line 38: Deprecated option RhostsRSAAuthentication
Could not load host key: /etc/ssh/ssh_host_dsa_key
Did not receive identification string from 10.1.0.1 port 43146
tirumaraiselvan commented 6 years ago

To remove the deprecated messages in the logs, just remove the deprecated options from sshd_config

sed -i '/KeyRegenerationInterval/d' /etc/ssh/sshd_config
sed -i '/ServerKeyBits/d' /etc/ssh/sshd_config
sed -i '/RSAAuthentication/d' /etc/ssh/sshd_config
sed -i '/RhostsRSAAuthentication/d' /etc/ssh/sshd_config
tirumaraiselvan commented 6 years ago

Also comment the line HostKey /etc/ssh/ssh_host_dsa_key to remove the host_dsa_key line

shahidhk commented 6 years ago

@tirumaraiselvan To remove the deprecated messages, you've mentioned /etc/ssh/sshd_config. But aren't we using /sshd-lib/sshd_config?

tirumaraiselvan commented 6 years ago

@shahidhk Right. You just need to remove it from here https://github.com/hasura/gitkube/blob/master/build/gitkubed/sshd_config

shahidhk commented 6 years ago

I figured.

shahidhk commented 6 years ago

@tirumaraiselvan Any idea about Did not receive identification string from 172.17.0.1 port 58866?