search

hasura / gitkube

Build and deploy docker images to Kubernetes using git push
Apache License 2.0
3.81k stars 207 forks source link

Upgrade k8s client-go version to 9.0 (close #85) #96

Closed prateekpandey14 closed 5 years ago

prateekpandey14 commented 5 years ago

  1. Use golang/dep instead of glide as Go dependency management tool

  2. Upgrade kubernets client-go version to latest 9.0 with required constraints as below in Gopkg.toml

    
[[constraint]]
name = "k8s.io/api"
version = "kubernetes-1.12.0"

[[constraint]] name = "k8s.io/apimachinery" version = "kubernetes-1.12.0"

[[constraint]] name = "k8s.io/apiextensions-apiserver" version = "kubernetes-1.12.0"

[[constraint]] name = "k8s.io/client-go" version = "9.0.0"


3.  Bump Go version 1.11 in Dockerfile for docker-build

4. Update vendor directory with latest kubernetes deps with respect to 9.0 client-go version.
fixes: #85
prateekpandey14 commented 5 years ago

cc @tirumaraiselvan PTAL

tirumaraiselvan commented 5 years ago

@prateekpandey14 This is awesome. I ll take a look.

tirumaraiselvan commented 5 years ago

I have just updated the e2e tests: https://github.com/hasura/gitkube/pull/98

Once merged, we can test this one out.

tirumaraiselvan commented 5 years ago

@prateekpandey14 This is looking great. I just ran the tests and it worked. And it solves #85 for EKS.

shark-h commented 5 years ago

Whoa! :tada: :tada: :dancer:

GIF

Awesome work @prateekpandey14! :muscle: :trophy: All of us at Hasura :heart: what you did.

We would love to send you some swag! Please fill this form.

If you have any questions, ask us on our Discord & Twitter!

Thanks again :hugs:

prateekpandey14 commented 5 years ago

Awesome @tirumaraiselvan .... great to hear, it solves #85 . Thanks @shark-h appreciate that !!!