Upgrade docker cli to 18.06

hasura / gitkube

Build and deploy docker images to Kubernetes using git push

Apache License 2.0

3.81k stars 207 forks source link

Upgrade docker cli to 18.06 #99

Closed seanprashad closed 5 years ago

seanprashad commented 5 years ago

Fixes #92: Multi-staged builds

To allow multi-staged builds, Docker 17.05 is required or higher is required on the daemon and the client. Documentation for Docker can be found here.

seanprashad commented 5 years ago

@tirumaraiselvan I've gone ahead and updated the release URL from 1.12.6 to 17.05. using the provided 64 bit linux tgz: https://get.docker.com/builds/Linux/x86_64/docker-17.05.0-ce.tgz.

Please let me know if we can polish this up any further 😁

tirumaraiselvan commented 5 years ago

@SeanPrashad I am not able to build this. Try make build-all in root directory.

Basically this fails

curl -o /tmp/docker-17.05 'https://get.docker.com/builds/Linux/x86_64/docker-17.05.0-ce.tgz'  && tar -xf /tmp/docker-17.05

tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors

seanprashad commented 5 years ago

@tirumaraiselvan Something odd is up - even the old link for https://get.docker.com/builds/Linux/x86_64/docker-1.12.6.tgz is returning a 403.

I'm going to see why the download link has changed!

Update: Other users are experiencing this too: https://github.com/moby/moby/issues/38105

seanprashad commented 5 years ago

@tirumaraiselvan I've updated the docker image to 17.06.0-ce from https://download.docker.com/linux/static/stable/x86_64 and make build-all is successful on my local machine.

If you could pull down the latest commit and test it locally, that would be great!

tirumaraiselvan commented 5 years ago

@SeanPrashad Shouldn't we use version 18.06 since that is out now?

seanprashad commented 5 years ago

Good idea @tirumaraiselvan! I've made the changes and rebuilt it locally with no errors:

If we can make this any better, please let me know! 😁

tirumaraiselvan commented 5 years ago

Docker cli has been upgraded but will be ineffective if the underlying host docker is not > 17.06